Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix method ambiguity with Base.in in julia nightly Version 1.12.0-DEV…514 #200

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix method ambiguity with Base.in in julia nightly Version 1.12.0-DEV…514 #200

wants to merge 1 commit into from

Conversation

OkonSamuel
Copy link
Member

@OkonSamuel OkonSamuel commented May 19, 2024 •
edited
Loading

@OkonSamuel OkonSamuel requested a review from ablaom May 19, 2024 20:18
@ablaom
Copy link
Member

ablaom commented May 19, 2024

I'm happy to approve this PR after appropriate testing (see below). However, it's is essentially a patch on top of a hack, for which I am personally to blame. That said, I think there is a fair chance that the overloading of in for MLJType (which is at least 3 years old, according to the blame) was rendered redundant when I refactored the learning networks code. The only way to find out for sure, would be to remove it and locally run

  • MLJBase tests
  • MLJTuning tests
  • MLJ#dev tests, with MLJ_TEST_INTEGRATION="true".

Is this something you would consider doing? Even if we accept the current PR, we probably want to run those tests anyway, so it's the same work really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablaom ablaom Awaiting requested review from ablaom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OkonSamuel @ablaom